Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calico v3.28.0 checksum and change calico default version #11234

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ehsan310
Copy link
Contributor

@ehsan310 ehsan310 commented May 25, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Calico v3.28.0 checksum and change calico default version

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Calico v3.28.0 checksum and change calico default version
Update calico apiserver deployment to use new readiness probe 

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 25, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 25, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ehsan310. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yankay
Copy link
Member

yankay commented May 27, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2024
@ehsan310 ehsan310 changed the title Calico v2.28.0 checksum and change calico default version Calico v3.28.0 checksum and change calico default version May 27, 2024
@ehsan310
Copy link
Contributor Author

I noticed calico api server health probe is changed, I'll update that as well.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2024
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehsan310, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2024
@ehsan310
Copy link
Contributor Author

ehsan310 commented Jun 3, 2024

@mzaian with this health probe changes do we have to put minimum version for calico ? how do we usually do minimum version ?

@mzaian
Copy link
Contributor

mzaian commented Jun 3, 2024

@mzaian with this health probe changes do we have to put minimum version for calico ? how do we usually do minimum version ?

There is no minimum version settings in kubespray. The calico api server is disabled by default see: https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubespray-defaults/defaults/main/download.yml#L112
If you would like to support previous version(s) you can do an if condition for the readinessProbe configuration.

make it backward compatible
@ehsan310
Copy link
Contributor Author

ehsan310 commented Jun 3, 2024

@mzaian it is now conditional on 3.28 version

@ehsan310
Copy link
Contributor Author

ehsan310 commented Jun 5, 2024

/retest-failed

@ehsan310
Copy link
Contributor Author

ehsan310 commented Jun 5, 2024

@mzaian something wrong with tests ?

@ehsan310
Copy link
Contributor Author

ehsan310 commented Jun 8, 2024

/retest-failed

@ant31
Copy link
Contributor

ant31 commented Jun 26, 2024

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants