-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rfc2136): add PTR optional support #4283
feat(rfc2136): add PTR optional support #4283
Conversation
Welcome @angeloxx! |
Hi @angeloxx. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
/unhold |
@angeloxx: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PR updated with changes from current master. |
/lgtm |
@angeloxx: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
/retitle feat(rfc2136): add PTR optional support |
I don't see a test that checks that PTR is enabled and we got a PTR record. |
You're right, I just added a test that verifies the (correct) creation of a reverse. |
fr: would be great if we could use an annotation per source i.e "external-dns.alpha.kubernetes.io/rfc2136-create-ptr: true/false" that would stand above global --rfc2136-create-ptr, so we would have more elasticity |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@chrxmvtik please add an issue or PR to define or implement this feature. It sounds that it could be helpful for the ones that need PTR record support. |
/lgtm |
Description
The PR extends the existing RFC2136 provider within external-dns, incorporating logic to handle PTR record creation and deletion alongside the management of other DNS record types. The functionality is disabled by default and can be activated with --rfc2136-create-ptr (similar to infoblox flag) in order to keep current behaviour during an upgrade.
Checklist