Re-enabled support for txt records

[ttarhan]

Description

PR #2811 (related to migrating to the new TXT registry format) broke support for TXT records (from the CRD source). This commit re-enables support for TXT records by changing missingTXTRecords to a map and enhancing the lookup in generateTXTRecord that suppresses TXT records related to migration.

Fixes: #3441

Note: This is my first attempt at golang, so please let me know if I got anything wrong here.

Checklist

• Unit tests updated
• [N/A] End user documentation updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: ttarhan / name: Tolga Tarhan (a0be4fb)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ttarhan
Once this PR has been reviewed and has the lgtm label, please assign seanmalloy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @ttarhan!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[ttarhan]

Hi @seanmalloy and @njuettner - I’m sure you are both super busy and this is low priority for the project. Is there anything I can do to help push this along?

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[szuecs]

@ttarhan would you mind rebase and hint me that you did, then I will check it again. Code lgtm from my side

[szuecs]

/remove-lifecycle stale

[mloiseleur]

It's superseded with #3916
/close

[k8s-ci-robot]

@mloiseleur: Closed this PR.

In response to this:

It's superseded with #3916
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.