-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controller does not delete listeners having specific tag (e.g. indicating listeners are externally managed) #3633
base: main
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @paulzhang97! |
Hi @paulzhang97. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: paulzhang97 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/check-cla |
@kishorj @johngmyers This is my first PR. Just want to check whether you would need any action from me. |
Can we have some review on this PR? |
Issue
The controller removes listeners not recognized by itself. In some deployments, listeners are created outside of the controller and managed externally. We need a way to tell the controller not to delete such listeners during reconciliation.
Related issue
Description
Listener synthesizer get the env variable
PREVENT_DELETION_TAG_NAME
specifying the tag name for not deleting listeners. It does not delete listeners tagged with the one set byPREVENT_DELETION_TAG_NAME
.Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く