-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to disable prometheus scraping #3597
base: main
Are you sure you want to change the base?
feat: Add ability to disable prometheus scraping #3597
Conversation
|
Welcome @TylerStaplerAtFanatics! |
Hi @TylerStaplerAtFanatics. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TylerStaplerAtFanatics The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -27,7 +27,7 @@ spec: | |||
{{- toYaml .Values.podLabels | nindent 8 }} | |||
{{- end }} | |||
annotations: | |||
{{- if not .Values.serviceMonitor.enabled }} | |||
{{- if not .Values.serviceMonitor.enabled and .Values.prometheusScrape.enabled}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong usage of helm and
keyword.
Correct is
{{- if and (not .Values.serviceMonitor.enabled) .Values.prometheusScrape.enabled }}
@TylerStaplerAtFanatics, hey, would you address the comments? Thanks |
2e6a765
to
ca686f8
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
👋 Sorry for the delay on this. We pursued a different mitigation internally and this fell off my radar. I have some free time today and I'm working on refactoring this |
Issue
Description
The current chart has no way of removing the
prometheus.io
annotations.We use Datadog to ingest prometheus metrics, and I noticed that the metrics emitted by the aws-load-balancer-controller are very high cardinality, increasing our costs dramatically.
The datadog agent looks for applications with the annotation
prometheus.io/scrape: "true"
Tests of the new flag (truncated for brevity)
Defaults (no change)
Disabling the scrape annotations
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯