-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check credential expiration timestamp when generating tokens #724
base: master
Are you sure you want to change the base?
Conversation
|
Welcome @lyoung-confluent! |
Hi @lyoung-confluent. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lyoung-confluent The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
What this PR does / why we need it:
There are two expirations which must be considered when using a signed EKS token:
The second case is particularly common when making frequent requests while using
AssumeRole
orAssumeRoleWithWebRequest
as mentioned in #590 as the default session timeout is 1 hour.This PR adds an additional check fetching the AWS credential expiration and using that as the returned expiration if it is before the 15 minute token expiration.
Which issue(s) this PR fixes
Unauthorized
error after 20+ minutes #590