-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting extra, non-selector labels on pods #1237
base: master
Are you sure you want to change the base?
Conversation
Welcome @den-is! |
Hi @den-is. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR is also a duplicate of #926 |
/ok-to-test |
Hi @den-is thanks for the PR. Could you please exclude the Helm version update from chart.yaml? We prefer to handle version changes in the release PRs. |
@mskanth972 Sure! Done. |
can you please squash the commits to one |
@mskanth972 but GitHub merge PR has the option to merge commits on merge, is not it? |
@mskanth972 Done. |
can we get this reviewed and merged please? we really need the ability to add pod labels. This is seems pretty straightforward |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: den-is, RyanStan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Denis Iskandarov <[email protected]> revert chart version bump Signed-off-by: Denis Iskandarov <[email protected]>
I hope someone finally approves this PR. After update/rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is this a bug fix or adding new feature?
New minor feature.
What is this PR about? / Why do we need it?
My recent deployment of efs-csi-driver in k8s cluster required me to set special labels on pods.
I was not able to do that using official chart.
So here is my PR.
Proposed changes do not interfere with or alter existing deployments.
What testing is done?
test values.yaml
Render chart:
Output:
Skipping setting additional pod labels, renders templates just fine.