Get node label from k8s service discovery #2893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a companion to opencost/opencost#2423 Without the changes from opencost/2423 this _will_ break queries in kubecost. Signed-off-by: Alex Nordlund <[email protected]>
|
Conflicts to resolve here. |
|
Conflicts |
|
No response, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This is a companion to opencost/opencost#2423
Does this PR rely on any other PRs?
Without the changes from opencost/2423 this will break queries in kubecost.
How does this PR impact users? (This is the kind of thing that goes in release notes!)
If you've setup your own
relabel_configsyou need to add the following configuration manually:Links to Issues or tickets this PR addresses or fixes
What risks are associated with merging this PR? What is required to fully test this PR?
Without the changes from the linked PR some queries will stop working, this should happen immediately and get caught by tests
How was this PR tested?
Have you made an update to documentation? If so, please provide the corresponding PR.