Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up certificate leases #15359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Jun 26, 2024

Fixes #15238

Proposed Changes

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 26, 2024
@skonto skonto requested review from dprotaso and removed request for izabelacg and ReToCode June 26, 2024 11:42
Copy link

knative-prow bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.62%. Comparing base (1dff15d) to head (c3984c1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15359      +/-   ##
==========================================
+ Coverage   84.59%   84.62%   +0.02%     
==========================================
  Files         219      219              
  Lines       13584    13584              
==========================================
+ Hits        11492    11496       +4     
+ Misses       1726     1724       -2     
+ Partials      366      364       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor Author

skonto commented Jun 26, 2024

/test istio-latest-no-mesh

@dprotaso
Copy link
Member

/test all

@skonto
Copy link
Contributor Author

skonto commented Jun 26, 2024

/test istio-latest-no-mesh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestControllerHA is flakey
2 participants