Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] [test-only] Rand fix #15354

Closed
wants to merge 2 commits into from
Closed

[wip] [test-only] Rand fix #15354

wants to merge 2 commits into from

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Jun 26, 2024

Fixes #

Proposed Changes

Release Note


knative-automation and others added 2 commits June 26, 2024 01:33
bumping knative.dev/caching 0520b50...46bd851:
  > 46bd851 upgrade to latest dependencies (# 876)
bumping knative.dev/pkg 8535fcc...ee1db86:
  > ee1db86 Update linter config and address lint warnings/failures (# 3068)
  > 26bc7b4 Register AuthenticatableType in schema (# 3069)

Signed-off-by: Knative Automation <[email protected]>
@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 26, 2024
Copy link

knative-prow bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.64%. Comparing base (1dff15d) to head (4cbf149).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15354      +/-   ##
==========================================
+ Coverage   84.59%   84.64%   +0.04%     
==========================================
  Files         219      219              
  Lines       13584    13584              
==========================================
+ Hits        11492    11498       +6     
+ Misses       1726     1721       -5     
+ Partials      366      365       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

knative-prow bot commented Jun 26, 2024

@skonto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
build-tests_serving_main 4cbf149 link true /test build-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@skonto
Copy link
Contributor Author

skonto commented Jun 26, 2024

All tests pass I will create a PR.

@dprotaso
Copy link
Member

thanks for verifying - update deps PR merged in

@dprotaso dprotaso closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants