-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename user container to main container #15330
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: EraKin575 <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: EraKin575 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @EraKin575! It looks like this is your first PR to knative/serving 🎉 |
Hi @EraKin575. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold we shouldn't be duplciating work |
@dprotaso I think we can remove this from hold now |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15330 +/- ##
==========================================
- Coverage 84.78% 84.59% -0.19%
==========================================
Files 218 219 +1
Lines 13504 13584 +80
==========================================
+ Hits 11449 11492 +43
- Misses 1688 1726 +38
+ Partials 367 366 -1 ☔ View full report in Codecov by Sentry. |
@EraKin575: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes #15007
Proposed Changes
*Renamed all
UserContainer
occurences toMainContainer
inpkg
package*
*
Release Note