Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define top level Permission for ci-schedule workflow #5069

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aditya7302
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Part of #5048

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 20, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign liangyuanpeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 20, 2024
@aditya7302
Copy link
Contributor Author

Here is the link of the CI Schedule Workflow(ci-schedule.yml) run with modified permissions :
https://github.com/aditya7302/karmada/actions/runs/9614970779

@zhzhuang-zju
Copy link
Contributor

Here is the link of the CI Schedule Workflow(ci-schedule.yml) run with modified permissions : https://github.com/aditya7302/karmada/actions/runs/9614970779

@aditya7302 refer to https://github.com/aditya7302/karmada/actions/runs/9614970779/workflow, there seems be no restriction on the permissions of ci

@aditya7302
Copy link
Contributor Author

@zhzhuang-zju I am sorry It was mistake I didn't notice I will provide you with another link of the local run with permissions added.

@aditya7302
Copy link
Contributor Author

@zhzhuang-zju here is the updated link of the workflow run with added permissions : https://github.com/aditya7302/karmada/actions/runs/9660518622/workflow

@zhzhuang-zju
Copy link
Contributor

/lgtm
cc @RainbowMango

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants