Fixes #1402: clarify readOnly applies to any value, not just properties
#1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot just properties). Format `true` and `false` code values
jdesrosiers
reviewed
Jun 19, 2024
jsonschema-validation.md
Outdated
| @@ -1,4 +1,4 @@ | |||
| # JSON Schema Validation: A Vocabulary for Structural Validation of JSON | |||
| e# JSON Schema Validation: A Vocabulary for Structural Validation of JSON | |||
There was a problem hiding this comment.
Suggested change
| e# JSON Schema Validation: A Vocabulary for Structural Validation of JSON | |
| # JSON Schema Validation: A Vocabulary for Structural Validation of JSON |
jsonschema-validation.md
Outdated
| instance is managed exclusively by the owning authority, and attempts by an | ||
| application to modify the value of this property are expected to be ignored or | ||
| application to modify the value of an instance are expected to be ignored or |
There was a problem hiding this comment.
When I read "an instance" my mind went to the "the entire JSON document", which isn't the intention. I think "instance" can be used to refer to a fragment of a JSON document, but we usually don't use it that way so this might be confusing.
What if we just leave it at "the value" and drop the "of" part entirely? Or we could say "that value within an instance"?
There was a problem hiding this comment.
how about :
If `readOnly` has a value of boolean `true`, it indicates that the
corresponding value in the instance is
managed exclusively by the owning authority, and attempts by an
application to modify the value are expected to be ignored or
rejected by that owning authority.
gregsdennis
approved these changes
Jun 20, 2024
jdesrosiers
approved these changes
Jun 21, 2024
|
is his ready to merge? I'm not sure how to reset the "PR Policy / Require Minimum Open Time (pull_request)" check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clarify that
readOnlyapplies to any value, not just properties.Re-format
trueandfalsecode valuesResolves #1402