Adding async support for tools #735
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tg1482
commented
Jun 5, 2024
Comment on lines
+130
to
+136
| if is_async_tool: | ||
| if tool.func: | ||
| # async tool defined using BaseTool class from crewai_tools | ||
| async_tool_run = tool._run | ||
| elif tool.coroutine: | ||
| # async tool defined using @tool decorator from langchain | ||
| async_tool_run = tool._arun |
There was a problem hiding this comment.
Currently when we define an async function using @tool decorator or BaseTools, they get created differently.
For @tool decorator - if the function is a coroutine, func=None and the function gets added to the coroutine attribute.
However, for BaseTools, thats not the case, it remains part of the func attribute. To absorb this complexity from the user's perspective, we do it this way so that users can still define their async tools using _run when using BaseTools. There is no change from the user's perspective other than just adding a async while defining the tool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following our discussion here, creating another PR with minimal changes to the codebase for supporting async tooling.
Previous PR here - #550
Added a test which passes for executing a pipeline with an async tool.