Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Standardize max_execution_time #708

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yuripourre
Copy link

@yuripourre yuripourre commented May 28, 2024

Changes the attribute name to a human-readable name, following the same pattern other attributes are doing.

@yuripourre yuripourre changed the title Standardize max_execution_time [Docs] Standardize max_execution_time May 28, 2024
@gvieira
Copy link
Collaborator

gvieira commented Jun 7, 2024

This goes against #599. I wonder what would be better.

@yuripourre
Copy link
Author

@gvieira, true! Personally, I prefer #599 approach but having any standard is better than mixed naming. Feel free to close this PR in favor of #599.

@contractorwolf
Copy link

if it makes a difference, when i was coding I had trouble using the documentation because I was guessing on the name to use in code because there werent examples that used all of the properties. A human readable description would be best to pair with the literal property name (as used in code). The friendly value doesnt really provide any use to developers.

@gvieira
Copy link
Collaborator

gvieira commented Jun 12, 2024

@contractorwolf I'm confused! 😄 Which one do you prefer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants