feat: Add Train feature for Crews #686
Conversation
Isn't that achievable by the memory feature instead?? |
|
@atb29 this is memory on steroids, it uses some of the memory work but allows you to train the crew before shipping, something we are testing internally, super excited about it, running some benchmarks now |
src/crewai/agents/executor.py
Outdated
| self, output: AgentFinish, human_feedback: str | None = None | ||
| ) -> None: | ||
| """Function to handle the process of the training data.""" | ||
| training_data_filename = "training_data.pkl" |
There was a problem hiding this comment.
Should we have these pkl file names in consts, maybe? This way we have a single place to find them.
There was a problem hiding this comment.
Definitely, I'll add it. Thanks @gvieira
src/crewai/agents/executor.py
Outdated
|
|
||
| if ( | ||
| not self.should_ask_for_human_input | ||
| and PickleHandler(training_data_filename).load() |
There was a problem hiding this comment.
I liked how you've used := above to prevent double-calling the load(). Should we try to do the same here?
There was a problem hiding this comment.
That makes sense, thanks, I'll change.
src/crewai/agents/executor.py
Outdated
| human_feedback = self._ask_human_input(output.return_values["output"]) | ||
|
|
||
| if self.crew._train: | ||
| self._training_handler(output, human_feedback) |
There was a problem hiding this comment.
Above, you've used a verb to name the method (_ask_human_input). This is perfect, because that's exactly what it does – there's even no need for documentation on the method in this case. For _training_handler however, it doesn't feel the same. How could we name this method to make it more clear what it's doing?
There was a problem hiding this comment.
Sure thing, I didn't have the proper time to review it, but I agree.
I'll review and change it to make it more intuitive.
src/crewai/agents/executor.py
Outdated
| training_data := PickleHandler(TRAINING_DATA_FILE).load() | ||
| and not self.should_ask_for_human_input | ||
| ): | ||
| training_data = PickleHandler(TRAINING_DATA_FILE).load() |
There was a problem hiding this comment.
Don't need this line anymore, right!?
src/crewai/utilities/fileHandler.py
Outdated
There was a problem hiding this comment.
I could swear I had this file renamed to properly match the convention: file_handler.py. 🤔
There was a problem hiding this comment.
Do you want me to rename it?
There was a problem hiding this comment.
Yes. I think it makes sense as we don't use pascalCase for file names.
src/crewai/utilities/fileHandler.py
Outdated
| file.write(message + "\n") | ||
|
|
||
|
|
||
| class PickleHandler: |
There was a problem hiding this comment.
If I got it right, this has started as a generic handler/helper for dealing with pickle marshaling, right!? However, I believe it got really tied up to the training concept – we have a lot of train-related functions. Should we maybe move this to a training module maybe, renaming it to something like TrainingHandler or something like that?
There was a problem hiding this comment.
I see your point, makes sense. I could have the PickleHandler as a utility file handler class.
And add a TrainingHandler that can Inherit the class and add the save_trained_data/append methods, what do you think?
There was a problem hiding this comment.
That would be perfect! Loved the idea!
The objective of this PR is to add training functionality for Crews.
With this functionality it will be possible to run the command
crewai train -n 2and 2 training iterations will be run so that future tasks can have greater quality and consistency.