Fix typo's within converter.py #645
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fiexed Type errors attemps > attempts
pythonbyte
reviewed
May 22, 2024
| @@ -64,7 +64,7 @@ def _create_instructor(self): | |||
|
|
|||
| inst = Instructor( | |||
| llm=self.llm, | |||
| max_attemps=self.max_attemps, | |||
| max_attemps=self.max_attempts, | |||
There was a problem hiding this comment.
I think we should check the "parameter" of the Instructor class max_attemps
There was a problem hiding this comment.
could not find reference to max_attemps anywhere else apart from tools_usage.py which has now been updated an commited to this PR
Updated line 293 max_attemps > max_attempts
gvieira
reviewed
Jun 7, 2024
| @@ -22,7 +22,7 @@ class Converter(BaseModel): | |||
| llm: Any = Field(description="The language model to be used to convert the text.") | |||
| model: Any = Field(description="The model to be used to convert the text.") | |||
| instructions: str = Field(description="Conversion instructions to the LLM.") | |||
| max_attemps: Optional[int] = Field( | |||
| max_attempts: Optional[int] = Field( | |||
| description="Max number of attemps to try to get the output formated.", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fiexed Type errors
attemps > attempts