Fix relationships #25876
Open
Fix relationships #25876
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mshima
reviewed
Apr 29, 2024
| @@ -78,7 +78,11 @@ _%> | |||
| public <% if (reactive) { %>Mono<<% } %>List<<%= instanceType %>><% if (reactive) { %>><% } %> getAll<%= entityClassPlural %>(<% if (fieldsContainNoOwnerOneToOne) { %>@RequestParam(name = "filter", required = false) String filter<% } %><% if (implementsEagerLoadApis && fieldsContainNoOwnerOneToOne) { %>,<% } %><% if (implementsEagerLoadApis) { %>@RequestParam(name = "eagerload", required = false, defaultValue = "true") boolean eagerload<% } %>) {<%- include('get_all_stream_template', {viaService: viaService}); -%> | |||
| log.debug("REST request to get all <%= entityClassPlural %>"); | |||
| <%_ if (viaService) { _%> | |||
| <% if (implementsEagerLoadApis && !dtoMapstruct) { %> | |||
| return <%= entityInstance %>Repository.findAllWithEagerRelationships()<% if (reactive) { %>.collectList()<% } %>; | |||
There was a problem hiding this comment.
findAllWithEagerRelationships should be used for collections where we should avoid multiple bags.
This error looks related to the repository since the relationships are not collections.
There was a problem hiding this comment.
What's the best way to proceed with getting this merged? Is it good enough for now?
There was a problem hiding this comment.
Looks like findAllWithEagerRelationships is used bellow, but this is ignoring the service layer and executing the repository.
It's probably required to add a parameter at service layer to make it optional like it's in the rest layer.
mshima
reviewed
Jun 24, 2024
| @@ -78,7 +78,11 @@ _%> | |||
| public <% if (reactive) { %>Mono<<% } %>List<<%= instanceType %>><% if (reactive) { %>><% } %> getAll<%= entityClassPlural %>(<% if (fieldsContainNoOwnerOneToOne) { %>@RequestParam(name = "filter", required = false) String filter<% } %><% if (implementsEagerLoadApis && fieldsContainNoOwnerOneToOne) { %>,<% } %><% if (implementsEagerLoadApis) { %>@RequestParam(name = "eagerload", required = false, defaultValue = "true") boolean eagerload<% } %>) {<%- include('get_all_stream_template', {viaService: viaService}); -%> | |||
| log.debug("REST request to get all <%= entityClassPlural %>"); | |||
| <%_ if (viaService) { _%> | |||
| <% if (implementsEagerLoadApis && !dtoMapstruct) { %> | |||
| return <%= entityInstance %>Repository.findAllWithEagerRelationships()<% if (reactive) { %>.collectList()<% } %>; | |||
| <%_ } else { _%> | |||
| return <%= entityInstance %>Service.findAll()<% if (reactive) { %>.collectList()<% } %>; | |||
There was a problem hiding this comment.
Service layer should not be bypassed.
Suggested change
| return <%= entityInstance %>Service.findAll()<% if (reactive) { %>.collectList()<% } %>; | |
| return <%= entityInstance %>Service.findAll(<% if (implementsEagerLoadApis) { %>eagerload<% } %>)<% if (reactive) { %>.collectList()<% } %>; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25846
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.