Add some windows hack for getChar #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstk
reviewed
Nov 22, 2018
| @@ -32,7 +33,7 @@ data PresentationCommand | |||
| -------------------------------------------------------------------------------- | |||
| readPresentationCommand :: IO PresentationCommand | |||
| readPresentationCommand = do | |||
| k <- readKey | |||
| k <- GetKey.getKey | |||
| case k of | |||
| "q" -> return Exit | |||
| "\n" -> return Forward | |||
There was a problem hiding this comment.
I tried applying these changes over the most recent version in hopes of getting it to work on Windows; testing this out on the first 01.md, it didn't appear to do anything differently. Advancing worked fine, but it was impossible to move backwards on slides.
However, commenting out this particular line and freeing \n seems to resolve some kind of fight between the windows console and getChar, allowing you to write a command and then flush the buffer with enter, making patat usable for me on W10 1809.
|
I added some more changes but it still does not work as smoothly as I would like to -- often you need to enter commands twice and I'm really not sure why that is happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.