-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to GitHub release/tag/commit in footer #4702
base: master
Are you sure you want to change the base?
Conversation
src/invidious/views/template.ecr
Outdated
( | ||
<% if CONFIG.modified_source_code_url %> | ||
<a href="<%= CONFIG.modified_source_code_url %>/releases/tag/<%= CURRENT_TAG %>"><%= CURRENT_TAG %></a> | ||
<% else %> | ||
<a href="https://github.com/iv-org/invidious/releases/tag/<%= CURRENT_TAG %>"><%= CURRENT_TAG %></a> | ||
<% end %> | ||
) | ||
</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please skip this section when a tag for the current commit is not found
<span> | ||
<%= translate(locale, "Current version: ") %> | ||
<% if CONFIG.modified_source_code_url %> | ||
<a href="<%= CONFIG.modified_source_code_url %>/commit/<%= CURRENT_COMMIT %>"><%= CURRENT_VERSION %>-<%= CURRENT_COMMIT %></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should we handle the case when the source code is hosted somewhere that doesn't adhere to this path structure?
Co-authored-by: syeopite <[email protected]>
Fix #4698
Thanks to @Fijxu