Static Analyzer (PHPStan) Integration #671
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
UlrichEckhardt
force-pushed
the
feat/phpstan
branch
4 times, most recently
from
7df86c9
to
861d949
Compare
UlrichEckhardt
force-pushed
the
feat/phpstan
branch
from
861d949
to
4fbfde3
Compare
UlrichEckhardt
force-pushed
the
feat/phpstan
branch
3 times, most recently
from
659e30c
to
dbfeee5
Compare
UlrichEckhardt
force-pushed
the
feat/phpstan
branch
from
dbfeee5
to
e923793
Compare
UlrichEckhardt
force-pushed
the
feat/phpstan
branch
from
e923793
to
ef3729b
Compare
Specifically that is - phpstan/phpstan - the linter itself - phpstan/extension-installer - convenience package for loading extensions - spaze/phpstan-disallowed-calls - an extension that checks for some additional flaws
The baseline lists the existing flaws that were found. This has two uses: - We can use a high sensitivity for scanning, without having to fix all issues right away. - It still prevents new issues from coming up and also tracks resolved issues.
This should prevent regressions in code flaws detected by PHPStan. Also, PHPStan complains when the baseline is not advanced after fixing a flaw. This should prevent a flaw from reappearing later on.
UlrichEckhardt
force-pushed
the
feat/phpstan
branch
from
ef3729b
to
e701ccb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
this PR integrates PHPStan into the Clockwork sources. The analyzer is automatically executed on every push using a Github action. As alternatives to PHPStan, there would be Psalm and perhaps SonarQube. I have worked with Psalm before and it works similarly to PHPStan. About SonarQube, I can't say much, but it seems to have a much larger scope. In particular, it provides a multi-language (not just PHP) framework and also includes support for making code reviews.
If you look at the README, there is a section on how to work with PHPStan, also the commit messages should contain some interesting context infos.
As for what drove me to develop this
Cheers!
Uli