-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest GLFW #6587
base: main
Are you sure you want to change the base?
Update to latest GLFW #6587
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
Looks good. We can merge after testing. Thanks! |
Possibly fixes #1673 |
Test draw example and O3DVisualizer. Also test legacy visualizer. |
Hi @errissa can you check the error in the documentation CI? Also, do all examples run for you? I got a crash in one draw.py example on Intel macOS. |
Works for me on intel Mac now. |
Everything works, except double clicking on a file in macOS does not open the file with Open3D. Need to check how macOS is passing the file name to glfw. |
Type
Motivation and Context
Updates Open3D to use the latest GLFW as the version we had been using is several years old and predates Mac API changes. Also, updated to build system to build GLFW as external project to make it consistent with the rest of Open3D's use of third party libraries.
Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description