-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.12 #6539
base: main
Are you sure you want to change the base?
Support Python 3.12 #6539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I do not have a system with both 3.12 and a CUDA GPU, so I can't test this properly. It would be good to get testing on both CUDA and MPS systems.
I did however update the installer and its readme so that it will allow python 3.12.
Hello @lstein,
I have both
- rtx 4090
- Python 3.12
What should I be testing?
Lincoln Stein ***@***.***> schrieb am Di., 25. Juni 2024,
02:56:
… ***@***.**** commented on this pull request.
Unfortunately I do not have a system with both 3.12 and a CUDA GPU, so I
can't test this properly. It would be good to get testing on both CUDA and
MPS systems.
I did however update the installer and its readme so that it will allow
python 3.12.
—
Reply to this email directly, view it on GitHub
<#6539 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZNARBAPKKKB6LFPLC4ROLZJC52VAVCNFSM6AAAAABJZ2IZGCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZXGA3DIOBXGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@JamesClarke7283 @lstein
|
I followd "QA instructions" as above until the step:
|
Summary
This PR updates the pinned dependencies in the pyproject.toml to support python3.12. this is a first draft.
If we are making use of asyncio in some capacity, it might improve performance a fair amount in some use cases, as a added bonus.
Related Issues / Discussions
Will likely fix #6214
Will also likely fix #5674 although, we may want to add scripts which update the pinned versions to the lowest version that x python version supports, as long as the version is equal to or greater than whats already in the dependencies.
QA Instructions
Merge Plan
Should be fairly simple to merge, as long as the tests pass, its mostly only the pyproject.toml that needs editing at the moment.
Checklist