Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adjust the alicloud metrics exporter and add RDS performance metrics #15563

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ZPascal
Copy link
Contributor

@ZPascal ZPascal commented Jun 25, 2024

Summary

  • The PR adds RDS Performance metrics

Checklist

  • No AI generated code was used in this PR
  • Build a dev release and test it
  • Add new unit tests
  • Adapt the documentation

Output

Screenshot 2024-06-25 at 16 12 22 1

related to #15238

@ZPascal ZPascal force-pushed the adjust-the-alicloud-metrics-exporter branch from 9f75e88 to d4bed9f Compare June 25, 2024 14:05
@powersj
Copy link
Contributor

powersj commented Jun 26, 2024

@ZPascal I see this is a draft, are you actually ready for a review once the lint issue is resolved?

@ZPascal ZPascal force-pushed the adjust-the-alicloud-metrics-exporter branch from e2b3c16 to d632ccc Compare June 27, 2024 13:21
@ZPascal
Copy link
Contributor Author

ZPascal commented Jun 27, 2024

@ZPascal I see this is a draft, are you actually ready for a review once the lint issue is resolved?

@powersj I think so. I still have some rework to do, e.g. new tests or documentation, but I think we can do it in parallel. In general, the feature offers the possibility to manage performance metrics. These metrics are not part of the CMS. I'm currently thinking about renaming the plugin. What do you think of this idea?

@ZPascal ZPascal force-pushed the adjust-the-alicloud-metrics-exporter branch from c0b4842 to a25731c Compare June 27, 2024 20:02
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 4.98 % for linux amd64 (new size: 255.9 MB, nightly size 243.7 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@ZPascal ZPascal changed the title Adjust the alicloud metrics exporter and add RDS performance metrics feat: Adjust the alicloud metrics exporter and add RDS performance metrics Jun 27, 2024
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 27, 2024
@powersj
Copy link
Contributor

powersj commented Jun 28, 2024

These metrics are not part of the CMS. I'm currently thinking about renaming the plugin. What do you think of this idea?

Check my understanding: CMS is the Cloud Monitor service, while the RDS is the relational database service? A user might not want one or the other.

Renaming it in the Telegraf config would be a breaking change and we do not want to do that.

What I would suggest doing is to add a config option that sets what metrics are captured, something like:

## Aliyun Metrics
## Specified which metrics to capture from Aliyun, choose from:
##  * cms - Cloud Monitor service
##  * rds - Relational Database service
# metrics = ["cms"]

A user can then add in rds if they want, or even use only rds. I suspect there is a possibility where we would want additional metrics from other services down the road. The other option is a 2nd plugin just for RDS, but this looks like we can keep them together given the wide overlap of the codebase.

In terms of docs, we would want to clarify at the top that this collects more than just CMS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants