-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adjust the alicloud metrics exporter and add RDS performance metrics #15563
base: master
Are you sure you want to change the base?
feat: Adjust the alicloud metrics exporter and add RDS performance metrics #15563
Conversation
9f75e88
to
d4bed9f
Compare
@ZPascal I see this is a draft, are you actually ready for a review once the lint issue is resolved? |
e2b3c16
to
d632ccc
Compare
@powersj I think so. I still have some rework to do, e.g. new tests or documentation, but I think we can do it in parallel. In general, the feature offers the possibility to manage performance metrics. These metrics are not part of the CMS. I'm currently thinking about renaming the plugin. What do you think of this idea? |
c0b4842
to
a25731c
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Check my understanding: CMS is the Cloud Monitor service, while the RDS is the relational database service? A user might not want one or the other. Renaming it in the Telegraf config would be a breaking change and we do not want to do that. What I would suggest doing is to add a config option that sets what metrics are captured, something like: ## Aliyun Metrics
## Specified which metrics to capture from Aliyun, choose from:
## * cms - Cloud Monitor service
## * rds - Relational Database service
# metrics = ["cms"] A user can then add in In terms of docs, we would want to clarify at the top that this collects more than just CMS. |
Summary
Checklist
Output
related to #15238