Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nicovideo.jp support #510

Draft
wants to merge 15 commits into
base: current
Choose a base branch
from
Draft

nicovideo.jp support #510

wants to merge 15 commits into from

Conversation

synzr
Copy link
Contributor

@synzr synzr commented May 21, 2024

progress

  • manage to replicate the domand requests
  • implement it with no account requirement
  • implement it with account requirement (not necessary)

closes #60

synzr added 3 commits May 20, 2024 21:59
TODO @synzr setting up something like vpn and test this
TODO @synzr ffmpeg doesn't work for no reason
@synzr
Copy link
Contributor Author

synzr commented May 22, 2024

waiting for double internal stream filter fix

image
image

UPD: got bored and fixed it maunally (cadbeef)

@synzr synzr marked this pull request as ready for review May 22, 2024 18:31
Copy link

@lostdusty lostdusty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@yeeterlol yeeterlol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, broken on my machine when downloading. All tests do pass and I confirmed with @synzr that it works on his machine so I think it's just minor skill issues.

@dumbmoron dumbmoron changed the title nicovideo.jp support (#60) nicovideo.jp support May 22, 2024
@synzr synzr requested a review from dumbmoron May 22, 2024 19:18
@synzr
Copy link
Contributor Author

synzr commented May 23, 2024

LGTM, broken on my machine when downloading. All tests do pass and I confirmed with @synzr that it works on his machine so I think it's just minor skill issues.

the ffmpeg-static just hangs with no error log when cobalt passes delivery.domand.nicovideo.jp URLs.
try to install ffmpeg manually and provide its absolute path via FFMPEG_BIN environment variable.

@wukko wukko self-requested a review May 23, 2024 03:43
@synzr
Copy link
Contributor Author

synzr commented May 23, 2024

LGTM, broken on my machine when downloading. All tests do pass and I confirmed with @synzr that it works on his machine so I think it's just minor skill issues.

the ffmpeg-static just hangs with no error log when cobalt passes delivery.domand.nicovideo.jp URLs. try to install ffmpeg manually and provide its absolute path via FFMPEG_BIN environment variable.

btw i can implement internal streams for m3u8 content to fix this

@yeeterlol
Copy link

yeeterlol commented May 23, 2024

LGTM, broken on my machine when downloading. All tests do pass and I confirmed with @synzr that it works on his machine so I think it's just minor skill issues.

the ffmpeg-static just hangs with no error log when cobalt passes delivery.domand.nicovideo.jp URLs. try to install ffmpeg manually and provide its absolute path via FFMPEG_BIN environment variable.

nvm the issue was that i forgot to install nscd since you need to install it on debian 12 and the running an instance guide said only ubuntu 22.04 would have this issue. probably a weird edge case idk

@synzr
Copy link
Contributor Author

synzr commented May 23, 2024

LGTM, broken on my machine when downloading. All tests do pass and I confirmed with @synzr that it works on his machine so I think it's just minor skill issues.

the ffmpeg-static just hangs with no error log when cobalt passes delivery.domand.nicovideo.jp URLs. try to install ffmpeg manually and provide its absolute path via FFMPEG_BIN environment variable.

nvm the issue was that i forgot to install nscd since you need to install it on debian 12 and the running an instance guide said ubuntu 22.04 would have this issue. probably a weird edge case idk

OH, IT'S WHY? i'm just using lmde rn.

@dumbmoron
Copy link
Member

dumbmoron commented May 25, 2024

LGTM, broken on my machine when downloading. All tests do pass and I confirmed with @synzr that it works on his machine so I think it's just minor skill issues.

the ffmpeg-static just hangs with no error log when cobalt passes delivery.domand.nicovideo.jp URLs. try to install ffmpeg manually and provide its absolute path via FFMPEG_BIN environment variable.

btw i can implement internal streams for m3u8 content to fix this

if this fixes it can u do that but in a separate PR and then rebase once it gets merged

@dumbmoron dumbmoron marked this pull request as draft May 30, 2024 20:48
@yeeterlol
Copy link

Nicovideo.jp is down for a while due to a cyberattack
https://www.theregister.com/2024/06/11/niconico_ebiten_kadokawa_cyberattack_outages/

@RyutoSetsujin
Copy link

Nicovideo.jp is currently up in a very basic form, only allowing you to watch the most popular videos from 2007 and 2008. You must either live in Japan or have a Japanese VPN to access the site.
They are removing the videos from 2007 tomorrow.
https://x.com/nico_nico_info/status/1802546484753428867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NicoNico support
6 participants