Adding functor input capability to ParsedAux #27959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbehne
suggested changes
Jun 21, 2024
There was a problem hiding this comment.
Overall: great job!
While my requested changes may look like a lot, you have already done the most important work: adding new capability. My small suggestions are aimed at making sure that we are following MOOSE's coding standards and trying to make this Auxkernel idiot-proof at the input file level.
General comments:
- I don't see a reference to the issue that this PR requests. I think it is related to Uniformize parsed capabilities #21244. If a related issue does not exist, you need to create one and reference it.
- Please edit the description of the PR (you left it blank) to describe what the PR does. Reference the issue it addresses.
- In order for your PR to merge, it needs to pass CIVET. One of the things that CIVET requires is that at least one of your commit messages should reference the relevant issue number (i.e.,
Addressed code review suggestions related to issue #21244.). Note the hashtag is crucial for CIVET to interpret the number as a reference.
Let me know if you have any questions or are ready for a re-review!
GiudGiud
reviewed
Jun 24, 2024
kyleeswanson
force-pushed
the
PR_parsedxyz
branch
from
42d10b4
to
1775155
Compare
…1244 Co-authored-by: Patrick Behne <[email protected]>
Added invalid expression test Issue idaholab#21244
kyleeswanson
force-pushed
the
PR_parsedxyz
branch
from
d3d0323
to
ec056f5
Compare
kyleeswanson
requested review from
bwspenc,
dschwen and
jiangwen84
as code owners
kyleeswanson
force-pushed
the
PR_parsedxyz
branch
from
ec056f5
to
f29ea63
Compare
pbehne
suggested changes
Jun 26, 2024
Issue idaholab#21244 Update framework/src/auxkernels/ParsedAux.C Co-authored-by: Patrick Behne <[email protected]> Apply suggestions from code review Co-authored-by: Patrick Behne <[email protected]> Fixed clang-tidy and formatting of ParsedAux.C Issue idaholab#21244
kyleeswanson
force-pushed
the
PR_parsedxyz
branch
from
9e4520d
to
ba44786
Compare
|
Job Documentation on b8ac89d wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Modules parallel on ba44786 : invalidated by @kyleeswanson Timed out |
pbehne
approved these changes
Jun 27, 2024
|
Job Coverage on b8ac89d wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
GiudGiud
approved these changes
Jun 27, 2024
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
This PR supports functor input capability for ParsedAux class - contributes to Issue #21244