Remove NSFV Action and NSFV component, use Physics

[GiudGiud]

refs #25642

[moosebuild]

Job Documentation on 805ae63 wanted to post the following:

View the site here

This comment will be updated on new commits.

[lindsayad]

Are the TH area users ready for this?

[GiudGiud]

@licharlot @tanoret

[GiudGiud]

Note that the old syntax remains completely functional. It's just the backend that changes (towards something that uses mostly the same code, just organized differently).
You do get a deprecation message.

[GiudGiud]

Public app failure is fake
EDIT:
non-unity was not, but fixed now

[lindsayad]

Note that the old syntax remains completely functional. It's just the backend that changes (towards something that uses mostly the same code, just organized differently).
You do get a deprecation message.

Oh nice 👍

[moosebuild]

Job Coverage on 805ae63 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Navier stokes

	62dc98	#27951 805ae6
	Total	Total	+/-	New
Rate	84.01%	84.58%	+0.57%	99.28%
Hits	17336	16196	-1140	276
Misses	3300	2952	-348	2

Diff coverage report

Full coverage report

Thermal hydraulics

	62dc98	#27951 805ae6
	Total	Total	+/-	New
Rate	89.14%	88.86%	-0.28%	-
Hits	14191	14111	-80	0
Misses	1729	1769	+40	0

Diff coverage report

Full coverage report

Full coverage reports

Reports

• framework
• chemical_reactions
• combined
• contact
• electromagnetics
• external_petsc_solver
• fluid_properties
• fsi
• functional_expansion_tools
• geochemistry
• heat_transfer
• level_set
• misc
• navier_stokes
• optimization
• peridynamics
• phase_field
• porous_flow
• ray_tracing
• rdg
• reactor
• richards
• scalar_transport
• solid_mechanics
• solid_properties
• stochastic_tools
• thermal_hydraulics
• xfem

This comment will be updated on new commits.

[joshuahansel]

I want to discuss

Had to regold because using a single physics for both components and the two components were using different advection methods. This is not one of the block restricted parameters.
The other solution would have been to use two physics. This would necessitate different variable names at the moment. There were some work on merging physics together
It is possible, it's also quite a bit of code to achieve something that so far is not really needed

In particular the part about needing different variables if needing more than one physics. I just want to understand any limitations before tighter integration between components and physics. But the change to this test is probably fine.

[joshuahansel]

I don't quite understand. So the Physics version is not going to take density as a functor?

[GiudGiud]

No the test for detecting whether a functor is constant doesn't work reliably. It just calls isConstant but many constants are not created in ConstantFunctors

[joshuahansel]

So how does Physics affect this? And does this test make sense to exist? Do we just need to improve isConstant somehow?

[GiudGiud]

Do we just need to improve isConstant somehow?

I dont see an easy way. Save for maybe evaluating it all over the mesh to check.

So how does Physics affect this?

I dont want to limit incompressible flow to not using the FP properties and the GFFP. I ll give it another try to see if I can re-enable this.

[GiudGiud]

Unless we start changing the block restrictions of created objects, I don't see how we could not use different variable names.

The physics create block restricted variables and UOs. If we have two physics, we would need them to modify the block restriction.

My preference is a single physics, with block restricted parameters on the components that fill the maps I have been creating to hold the parameters

[joshuahansel]

Ok, I'm good with these changes, so just checking for any dissent by @licharlot or @tanoret before approval.

[moosebuild]

Job Coverage on 805ae63 wanted to post the following:

The following coverage requirement(s) failed:

• thermal_hydraulics coverage rate 88.86% is less than the required 89.0%

[GiudGiud]

let's go?

[licharlot]

Looks good to me. Thanks for adding the transition tutorial.