Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic tagging and deploy on source index #27835

Draft
wants to merge 12 commits into
base: next
Choose a base branch
from

Conversation

GiudGiud
Copy link
Contributor

@GiudGiud GiudGiud commented Jun 9, 2024

refs #25387

I think this will be a nice feature of Dempsey, Casey, Jason, Derek and my work on the tagging capabilities of MooseDocs

Figuring out how to create the html page automatically was a little too much for this unfunded pursuit, and unfortunately this precludes having two search pages (there is some more work to do there). So I removed the EM one. The EM one was still a big help in getting this one going so the credit should still go to Casey.

Append modules/filter/index_framework.html on the address of the PR to see the page. I ll post a link when it s up and I get to it

@moosebuild
Copy link
Contributor

moosebuild commented Jun 9, 2024

Job Documentation on 8854eb7 wanted to post the following:

View the site here

This comment will be updated on new commits.

- remove a bad tag
- add a missing title
- make background white
- remove tags from EM modules as they get auto-tagged
@loganharbour
Copy link
Member

Not sure how this is automatic?

Nearly all of these can be added automatically by the syntax extension. I don't think requiring another line of boilerplate for every object is a good idea

@GiudGiud
Copy link
Contributor Author

I ll look into that extension.

The boilerplate is needed to trigger the tagging extension only on a selection of pages

@GiudGiud
Copy link
Contributor Author

I think we could trigger a new tagging extension on syntax commands.

That is probably the best option. I ll modify the PR. Thanks for the idea

@GiudGiud GiudGiud self-assigned this Jun 11, 2024
@moosebuild
Copy link
Contributor

Job Coverage on 8854eb7 wanted to post the following:

Framework coverage

0445d4 #27835 8854eb
Total Total +/- New
Rate 85.07% 85.07% -0.00% 77.39%
Hits 104086 104085 -1 154
Misses 18264 18265 +1 45

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 77.39% is less than the suggested 90.0%

This comment will be updated on new commits.

@GiudGiud GiudGiud marked this pull request as draft June 17, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants