Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New materials and kernels for anisotropic grain growth-Gauss branch #27816

Open
wants to merge 11 commits into
base: next
Choose a base branch
from
Open

New materials and kernels for anisotropic grain growth-Gauss branch #27816

wants to merge 11 commits into from

Conversation

Leni-Yeo
Copy link

@Leni-Yeo Leni-Yeo commented Jun 7, 2024

#closes #27774

@Leni-Yeo Leni-Yeo requested a review from dschwen as a code owner June 7, 2024 03:15
@GiudGiud
Copy link
Contributor

GiudGiud commented Jun 11, 2024 •
edited
Loading

If you cant see the output of the precheck step that fails:



##########################################################################
ERROR: MOOSE prefers two spaces instead of tabs. The following files contain tab characters:
	modules/phase_field/include/materials/GAMMAandLanisoGAUSS.h
	modules/phase_field/include/materials/GAMMAanisoGAUSS.h
	modules/phase_field/src/materials/EPSandMandLanisoGAUSS.C
	modules/phase_field/src/materials/EPSandManisoGAUSS.C
	modules/phase_field/src/materials/GAMMAandLanisoGAUSS.C
	modules/phase_field/src/materials/GAMMAanisoGAUSS.C

ERROR: The following files are executable but shouldn't be:
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/EPSILON_MODEL/EPSandMGAUSS/BI_EPSandMGAUSS/BI_EPSandMGAUSS.i
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/EPSILON_MODEL/EPSandMGAUSS/BI_EPSandMGAUSS/Inclined_20degrees_CCW.png
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/EPSILON_MODEL/EPSandMGAUSS/BI_EPSandMGAUSS/Inclined_40degrees_CCW.png
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/EPSILON_MODEL/EPSandMGAUSS/BI_EPSandMGAUSS/Vertical.png
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/EPSILON_MODEL/EPSandMGAUSS/TRI_EPSandMGAUSS/TRI_EPSandMGAUSS.i
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/EPSILON_MODEL/EPSandMandLGAUSS/BI_EPSandMandLGAUSS/BI_EPSandMandLGAUSS.i
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/EPSILON_MODEL/EPSandMandLGAUSS/BI_EPSandMandLGAUSS/Inclined_20degrees_CCW.png
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/EPSILON_MODEL/EPSandMandLGAUSS/BI_EPSandMandLGAUSS/Inclined_40degrees_CCW.png
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/EPSILON_MODEL/EPSandMandLGAUSS/BI_EPSandMandLGAUSS/Vertical.png
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/EPSILON_MODEL/EPSandMandLGAUSS/TRI_EPSandMandLGAUSS/TRI_EPSandMandLGAUSS.i
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/GAMMA_MODEL/GAMMAGAUSS/BI_GAMMAGAUSS/BI_GAMMAGAUSS.i
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/GAMMA_MODEL/GAMMAGAUSS/BI_GAMMAGAUSS/Inclined_20degrees_CCW.png
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/GAMMA_MODEL/GAMMAGAUSS/BI_GAMMAGAUSS/Inclined_40degrees_CCW.png
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/GAMMA_MODEL/GAMMAGAUSS/BI_GAMMAGAUSS/Vertical.png
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/GAMMA_MODEL/GAMMAGAUSS/TRI_GAMMAGAUSS/TRI_GAMMAGAUSS.i
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/GAMMA_MODEL/GAMMAandLGAUSS/BI_GAMMAandLGAUSS/BI_GAMMAandLGAUSS.i
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/GAMMA_MODEL/GAMMAandLGAUSS/BI_GAMMAandLGAUSS/Inclined_20degrees_CCW.png
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/GAMMA_MODEL/GAMMAandLGAUSS/BI_GAMMAandLGAUSS/Inclined_40degrees_CCW.png
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/GAMMA_MODEL/GAMMAandLGAUSS/BI_GAMMAandLGAUSS/Vertical.png
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/GAMMA_MODEL/GAMMAandLGAUSS/TRI_GAMMAandLGAUSS/TRI_GAMMAandLGAUSS.i
	modules/phase_field/include/kernels/EPSILONmodelKERNEL1stGAUSS.h
	modules/phase_field/src/kernels/EPSILONmodelKERNEL1stGAUSS.C
	modules/phase_field/test/tests/Gaussian_anisotropy/EPSILON_MODEL/EPSandMGAUSS/BI_EPSandMGAUSS/BI_EPSandMGAUSS.i
	modules/phase_field/test/tests/Gaussian_anisotropy/EPSILON_MODEL/EPSandMandLGAUSS/BI_EPSandMandLGAUSS/BI_EPSandMandLGAUSS.i
	modules/phase_field/test/tests/Gaussian_anisotropy/GAMMA_MODEL/GAMMAGAUSS/BI_GAMMAGAUSS/BI_GAMMAGAUSS.i

ERROR: The following files contain unicode characters
Run: perl -ne 'print if /[^[:ascii:]]/' <filename>
to see what lines are the problem
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/EPSILON_MODEL/EPSandMGAUSS/BI_EPSandMGAUSS/BI_EPSandMGAUSS.i
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/EPSILON_MODEL/EPSandMGAUSS/TRI_EPSandMGAUSS/TRI_EPSandMGAUSS.i
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/EPSILON_MODEL/EPSandMandLGAUSS/BI_EPSandMandLGAUSS/BI_EPSandMandLGAUSS.i
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/EPSILON_MODEL/EPSandMandLGAUSS/TRI_EPSandMandLGAUSS/TRI_EPSandMandLGAUSS.i
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/GAMMA_MODEL/GAMMAGAUSS/BI_GAMMAGAUSS/BI_GAMMAGAUSS.i
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/GAMMA_MODEL/GAMMAGAUSS/TRI_GAMMAGAUSS/TRI_GAMMAGAUSS.i
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/GAMMA_MODEL/GAMMAandLGAUSS/BI_GAMMAandLGAUSS/BI_GAMMAandLGAUSS.i
	modules/phase_field/examples/Spherical-Gaussian_5D_anisotropy/GAMMA_MODEL/GAMMAandLGAUSS/TRI_GAMMAandLGAUSS/TRI_GAMMAandLGAUSS.i
	modules/phase_field/include/materials/EPSandMandLanisoGAUSS.h
	modules/phase_field/include/materials/EPSandManisoGAUSS.h
	modules/phase_field/include/materials/GAMMAandLanisoGAUSS.h
	modules/phase_field/include/materials/GAMMAanisoGAUSS.h
	modules/phase_field/src/materials/EPSandMandLanisoGAUSS.C
	modules/phase_field/src/materials/EPSandManisoGAUSS.C
	modules/phase_field/src/materials/GAMMAandLanisoGAUSS.C
	modules/phase_field/src/materials/GAMMAanisoGAUSS.C
	modules/phase_field/test/tests/Gaussian_anisotropy/EPSILON_MODEL/EPSandMGAUSS/BI_EPSandMGAUSS/BI_EPSandMGAUSS.i
	modules/phase_field/test/tests/Gaussian_anisotropy/EPSILON_MODEL/EPSandMandLGAUSS/BI_EPSandMandLGAUSS/BI_EPSandMandLGAUSS.i
	modules/phase_field/test/tests/Gaussian_anisotropy/GAMMA_MODEL/GAMMAGAUSS/BI_GAMMAGAUSS/BI_GAMMAGAUSS.i
	modules/phase_field/test/tests/Gaussian_anisotropy/GAMMA_MODEL/GAMMAandLGAUSS/BI_GAMMAandLGAUSS/BI_GAMMAandLGAUSS.i
##########################################################################

once this is fixed, testing can proceed.

Who are you working with on this? Anyone at INL or another national lab?

@Leni-Yeo
Copy link
Author

Leni-Yeo commented Jun 11, 2024 •
edited
Loading

@GiudGiud

Hello. Thank you for that. I will try fixing them.

I am not working with anyone in particular; just my advisor-Dr. Jacob Bair at OSU. I am the author of (https://doi.org/10.1186/s41313-021-00035-3)
(https://doi.org/10.1016/j.jcrysgro.2023.127508) - Lenissongui Yeo. This is part of my dissertation. I am just trying push it into MOOSE if possible.

@GiudGiud
Copy link
Contributor

thanks for the info and sharing your work

@dschwen can you please try to find the right person (if not yourself) to consider & review this?

@moosebuild
Copy link
Contributor

Job Precheck on ee13955 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/27816/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format ca913d972d5b15fae47e7514eb81d76b77718ad4

@Leni-Yeo
Copy link
Author

@dschwen
Hi.
The "Precheck" says "Passed". Do I just need to wait at this point until you go through it?
Just wanted to check since it's my first time doing this.

@GiudGiud
Copy link
Contributor

Yes you just need to wait for a review.
Maybe @laagesen can help here too, we just need someone in charge of phase field to select a reviewer

@Leni-Yeo
Copy link
Author

@GiudGiud
No problem. Thank you!

@moosebuild
Copy link
Contributor

moosebuild commented Jun 25, 2024 •
edited
Loading

Job Documentation on 8a354ff wanted to post the following:

View the site here

This comment will be updated on new commits.

@Leni-Yeo
Copy link
Author

@GiudGiud
I checked the results and fixed some errors I could fix on my side. Can you activate it once again if possible? It is back at "Developer needed to activate"

@moosebuild
Copy link
Contributor

Job Coverage on 8a354ff wanted to post the following:

Framework coverage

68a347 #27816 8a354f
Total Total +/- New
Rate 85.06% 85.06% -0.00% -
Hits 104403 104402 -1 0
Misses 18335 18336 +1 0

Diff coverage report

Full coverage report

Modules coverage

Phase field

68a347 #27816 8a354f
Total Total +/- New
Rate 86.00% 87.38% +1.38% 96.08%
Hits 13659 16065 +2406 2405
Misses 2224 2321 +97 98

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschwen dschwen Awaiting requested review from dschwen dschwen is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@dschwen dschwen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New materials and kernels for anisotropic grain growth.
4 participants
@Leni-Yeo @GiudGiud @moosebuild @dschwen