Ghosting

[oanaoana]

This PR addresses #27203.

[moosebuild]

Job Documentation on 3b8c7dd wanted to post the following:

View the site here

This comment will be updated on new commits.

[vincentlaboure]

As discussed with @oanaoana, the proposed test already passes with the current version of MOOSE (without her changes) so a better test should be conceived to be fully convincing. Ideally such a test would show a memory spike during mesh initialization before the change but not after.

[moosebuild]

Job Coverage on 3b8c7dd wanted to post the following:

Framework coverage

	62dc98	#27810 3b8c7d
	Total	Total	+/-	New
Rate	85.06%	85.03%	-0.03%	12.50%
Hits	104412	104417	+5	6
Misses	18335	18378	+43	42

Diff coverage report

Full coverage report

Modules coverage

Heat transfer

	62dc98	#27810 3b8c7d
	Total	Total	+/-	New
Rate	88.95%	88.99%	+0.04%	100.00%
Hits	4258	4275	+17	18
Misses	529	529	-	0

Diff coverage report

Full coverage report

Full coverage reports

Reports

• framework
• chemical_reactions
• combined
• contact
• electromagnetics
• external_petsc_solver
• fluid_properties
• fsi
• functional_expansion_tools
• geochemistry
• heat_transfer
• level_set
• misc
• navier_stokes
• optimization
• peridynamics
• phase_field
• porous_flow
• ray_tracing
• rdg
• reactor
• richards
• scalar_transport
• solid_mechanics
• solid_properties
• stochastic_tools
• thermal_hydraulics
• xfem

Warnings

• framework new line coverage rate 12.50% is less than the suggested 90.0%

This comment will be updated on new commits.

[lindsayad]

it would be good to create a framework test to try and improve coverage

[lindsayad]

At the point that you've identified the element as needing to be ghosted, you can break out of the boundary id and side loops

[permcody]

Breaking out of two loops the easiest way requires a goto statement, which is arguably as much bad as it is good. I'm going to suggest that we simply create "a good first" issue to revisit this since you've pointed it out in this review, but I wouldn't necessarily hold up the merge of this PR for this single optimization.

[lindsayad]

People talk about goto being bad, but I think it's a dogma. goto can be used very effectively and clearly and would be a very reasonable two line addition here to save potentially O(n sides) * O(n boundary IDs) unnecessary looping

[lindsayad]

the amount of time required to implement this change should be under two minutes

[moosebuild]

Job Precheck on 912a1bc wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/27810/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 95d6f4fd6c8286879312d2633ce3f0af5de48949

[lindsayad]

Suggested change

	goto countBreak;
	countBreak:
	coupled_elements.insert(std::make_pair(elem, _null_mat));
	{
	coupled_elements.insert(std::make_pair(elem, _null_mat));
	goto countBreak;
	}
	countBreak: