-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a material interface reaction #27737
Conversation
test/tests/interfacekernels/1d_interface/ADMatreaction_1D_steady.i
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good first draft, but I think I see some errors.
Job Precheck on 34794f0 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
You're failing precheck because of trailing whitespace
|
Job Documentation on c1b574e wanted to post the following: View the site here This comment will be updated on new commits. |
@lindsayad I noticed that Akanksha's csvdiff was failing because she wasn't specifying the right csv output file in her |
I usually create a symlink in the gold file directory. This removes the possibility of a race condition |
Job Coverage on c1b574e wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the merge commit. You can use rebase if you need something new on next
f844c4f
to
bb6839e
Compare
code with deleted whitespace addressing errors related to CSV files from review standardized test output files adding unique requirement in tests revised tests to resolve errors
94da5b3
to
96efb8c
Compare
@lindsayad I think the tests should all be good now, but we have a couple of the modules test that are timing out. |
framework/doc/content/source/interfacekernels/ADMatInterfaceReaction.md
Outdated
Show resolved
Hide resolved
framework/doc/content/source/interfacekernels/ADMatInterfaceReaction.md
Outdated
Show resolved
Hide resolved
framework/doc/content/source/interfacekernels/ADMatInterfaceReaction.md
Outdated
Show resolved
Hide resolved
framework/doc/content/source/interfacekernels/ADMatInterfaceReaction.md
Outdated
Show resolved
Hide resolved
framework/doc/content/source/interfacekernels/ADMatInterfaceReaction.md
Outdated
Show resolved
Hide resolved
test/tests/interfacekernels/1d_interface/ADMatreaction_1D_steady.i
Outdated
Show resolved
Hide resolved
test/tests/interfacekernels/1d_interface/ADMatreaction_1D_transient.i
Outdated
Show resolved
Hide resolved
test/tests/interfacekernels/1d_interface/ADMatreaction_1D_transient.i
Outdated
Show resolved
Hide resolved
test/tests/interfacekernels/1d_interface/ADMatreaction_1D_transient.i
Outdated
Show resolved
Hide resolved
thanks for your contribution @parmar0 ! |
Co-authored-by: Alex Lindsay <[email protected]>
3ff798b
to
dbce7fa
Compare
@lindsayad We've tried to remove any references to the large_media submodule (revert to previous commit, force push), but it seems that we're still trying to change it somehow. We haven't touched that folder. Is this something we need to put more time into, or is there an easy way to remove that from the PR at this point |
@ke7kto The easiest way at this point, with the current history, is fixing up the commit that contains the update.
EDIT: you might need to EDIT2: During the autosquash procedure, it'll likely drop you into VIM. Inspect the sequence of commits and if its to your liking, simply |
dbce7fa
to
edb4651
Compare
@ke7kto Looks like your last formatting commit didn't apply through the push - did you not see it in the rebase? EDIT: Good thing is - I don't see the large media submodule in this anymore! 😄 |
framework/doc/content/source/interfacekernels/ADMatInterfaceReaction.md
Outdated
Show resolved
Hide resolved
framework/doc/content/source/interfacekernels/ADMatInterfaceReaction.md
Outdated
Show resolved
Hide resolved
test/tests/interfacekernels/1d_interface/ADMatreaction_1D_steady.i
Outdated
Show resolved
Hide resolved
…rfaceReaction terms to documentation
…dition created in the test
framework/doc/content/source/interfacekernels/ADMatInterfaceReaction.md
Outdated
Show resolved
Hide resolved
framework/doc/content/source/interfacekernels/ADMatInterfaceReaction.md
Outdated
Show resolved
Hide resolved
test/tests/interfacekernels/1d_interface/ADMatreaction_1D_steady.i
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Lindsay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your hard work on this @ke7kto and opening my eyes to these neat interface conditions. Will merge pending tests passing
Add a material interface reaction. Closes #27736
Reason
Need to model variable reaction rates.
Design
Adding a class with reaction rate coefficients specified by AD Material Properties.
Impact
Allows users to model variable reaction rates.