[memory] Fix read_cstring trying to read too far #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
reviewed
Jun 2, 2024
hugsy
requested changes
Jun 9, 2024
| @@ -10597,10 +10597,34 @@ def read_cstring(self, | |||
| encoding = encoding or "unicode-escape" | |||
| length = min(address | (DEFAULT_PAGE_SIZE-1), max_length+1) | |||
|
|
|||
| while not self.get_section(address + length - 1) and length > 0: | |||
There was a problem hiding this comment.
I didn't measure it but I think this approach may cause a slow down in read_cstring for long printable strings. I also find quite complex for what is actually intended to do because you'll be impacting all cases of use of this function for only a minority of cases that violate page boundary.
A simpler approach would be to remove all this, simply let self.read execute: if a gdb.MemoryError, use the exception information calculate the maximum valid length and re-read.
Another approach would be to check early on when setting length that address + length is a readable address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #1055