Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect few contributions on philosophy.md that were not reflected on #8294 #8690

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mreraser
Copy link
Contributor

What does this PR do?

Hello!馃榾

In the previous PR, I mistakenly named the file philosopy.md and later corrected it to philosophy.md.

However, during this process, it was identified by @heuristicwave that the reviews provided by @jungnerd were not reflected in the PR. I apologize for the oversight and any inconvenience caused. I should have double-checked before the PR was merged.

I am resubmitting the PR with the latest changes included. Thank you for your understanding.

from #7940

Before submitting

Who can review?

@heuristicwave @stevhliu

Some contributions were not reflected previously, so I am resubmitting them.
@sayakpaul sayakpaul requested review from yiyixuxu and stevhliu and removed request for yiyixuxu June 25, 2024 07:37
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for coming back to apply those fixes! Feel free to ping me for another review once all the feedback from @jungnerd has been incorporated 馃檪

docs/source/ko/conceptual/philosophy.md Outdated Show resolved Hide resolved
docs/source/ko/conceptual/philosophy.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants