Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for issue #590 #1281

Closed
wants to merge 1 commit into from
Closed

Conversation

izotos
Copy link

@izotos izotos commented Mar 8, 2018

Possible fix for #590

@johman10
Copy link

johman10 commented May 2, 2018

I confirm that this fixes the issue mentioned in #590. Is there any chance this will get merged?

@peterswimm
Copy link
Contributor

Has anyone been able to confirm it does not BREAK other aspects of the Slack integration?

@johman10
Copy link

johman10 commented May 2, 2018

@peterswimm which features should be tested to make sure this doesn't break anything? I can probably test it if I have a bit more of a scope.

@erodewald
Copy link

Happy to help verify as well @peterswimm, just not sure what specifically. We're using this PR internally for a slash command exclusively with no issues.

@izotos
Copy link
Author

izotos commented May 3, 2018

@peterswimm I can also confirm this works for us as well, though we only use it in our development env. Also unsure what I should be testing, I can just list the things that do work in our applications:

  • API calls (bot.api.)
  • Interactive messages (replyInteractive, replyInThread)
  • Dialog (replyWithDialog) which fails in current version

jnv added a commit to jnv/botkit that referenced this pull request May 23, 2018
@benbrown benbrown changed the base branch from master to legacy May 3, 2019 21:00
@benbrown benbrown added the legacy pertaining to version 0.7 or below label May 4, 2019
@ryansydnor
Copy link
Collaborator

This is handled more comprehensively by #1453. Closing in favor of that PR.

@ryansydnor ryansydnor closed this Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug legacy pertaining to version 0.7 or below Slack-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants