Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Todo card item textfield with combobox #20958

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Jun 2, 2024

Proposed change

Enhance the todo list new item box to autocomplete existing checked items. I thought this was a nice usability improvement, though the code ended up being way more difficult to get exactly right than I initially anticipated, so I can't say for sure if the feature is worth the additional code complexity.

todo-combobox

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Summary by CodeRabbit

  • New Features

    • Added a noButton property to the combo box component, allowing users to hide the button if desired.
    • Enhanced the todo list card with a new combo box for item input, improving the user experience with better filtering and selection options.
  • Improvements

    • Updated event handling and rendering logic in the todo list card for more responsive interactions and better performance.

This comment was marked as off-topic.

coderabbitai[bot]

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant