Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate translation in vscode taks: Code Coverage #120434

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Thomas55555
Copy link
Contributor

Breaking change

Proposed change

Sometimes I forget to generate the translations before running a code coverage report and the tests fail, and spending time on finding the cause of it. With this PR, the translation for the integration is done before. If the integration has no strings.json the generating of the translation fails and just the tests run.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Thomas55555 Thomas55555 requested a review from a team as a code owner June 25, 2024 15:42
@home-assistant home-assistant bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels Jun 25, 2024
@Thomas55555 Thomas55555 changed the title Generate translation in code coverage Generate translation in vscode taks: Code Coverage Jun 25, 2024
@gjohansson-ST
Copy link
Member

Can't we just use dependsOn to run the translations development beforehand. It's pretty fast so no need to develop perhaps just for the individual integration.

"type": "shell",
"command": "python3 -m pytest ./tests/components/${input:integrationName}/ --cov=homeassistant.components.${input:integrationName} --cov-report term-missing --durations-min=1 --durations=0 --numprocesses=auto",
"command": "python3 -m script.translations develop --integration ${input:integrationName} & python3 -m pytest ./tests/components/${input:integrationName}/ --cov=homeassistant.components.${input:integrationName} --cov-report term-missing --durations-min=1 --durations=0 --numprocesses=auto",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be a dependsOn as @gjohansson-ST said. Not sure this make sense to run every time

@Thomas55555
Copy link
Contributor Author

The problem is, this works only if Compile English translations for a given integration is successful. Bute for integrations without translations this doesn't work.

@Thomas55555 Thomas55555 marked this pull request as draft June 27, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed code-quality small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants