Detect WebGL support on BrowserInfo #6931
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
commented
Jun 20, 2024
philippjfr
commented
Jun 24, 2024
hoxbro
reviewed
Jun 25, 2024
There was a problem hiding this comment.
An electron bug caused the issue with Jupyter Desktop. See the comments at bokeh/bokeh#13665. It was fixed by deleting a specific folder.
I don't know if this would solve the problem more than hide it. I could be wrong.
| @@ -505,6 +505,8 @@ def _render(self, doc, comm, root): | |||
| Store.current_backend = loaded_backend | |||
| backend = self.backend or Store.current_backend | |||
| renderer = Store.renderers[backend] | |||
| if state.browser_info and 'webgl' in renderer.param: | |||
| renderer.webgl = state.browser_info.webgl | |||
There was a problem hiding this comment.
I don't think it is Panel job to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects webgl support, e.g. so we can toggle webgl rendering automatically in HoloViews.