Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(pkg/chartutil): add missing dots and indentation to defaultValues #13111

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rawtaz
Copy link

@rawtaz rawtaz commented Jun 14, 2024

Pure cosmetics, add missing dots to a few comments and make indentation coherent between different parts of the defaultValues YAML.

What this PR does / why we need it:

It makes the generated values.yaml file from helm create more correct/clean.

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

The contribution guidelines say that one should create a new issue if there isn't one for the change one is creating a PR for. I figured that is not worth anyone's time for small changes like this, but let me know if I should still open an issue even fore style changes like this one! I also wasn't sure if the branch name should still be prefixed with feat/ in its name, it's not clear from the contribution/developer docs.

Pure cosmetics, add missing dots to a few comments and make indentation
coherent between different parts of the defaultValues YAML.

Signed-off-by: Leo R. Lundgren <[email protected]>
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant