Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jump_backwards behaviour when jumplist is at capacity #10968

Merged
merged 9 commits into from
Jun 18, 2024
Merged

Fix jump_backwards behaviour when jumplist is at capacity #10968

merged 9 commits into from
Jun 18, 2024
+20 −4

Commits on Jun 15, 2024

  1. Fix jump_backwards behaviour when jumplist is at capacity

    @thomasschafer
    thomasschafer committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    6524d5f View commit details
    Browse the repository at this point in the history

  2. Decrement self.current while popping from front

    @thomasschafer
    thomasschafer committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    12f8df1 View commit details
    Browse the repository at this point in the history

  3. Fix issue with conflicting updates to self.current

    @thomasschafer
    thomasschafer committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    f6ac3d6 View commit details
    Browse the repository at this point in the history

  4. Realised that truncate is intentional

    @thomasschafer
    thomasschafer committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    c586712 View commit details
    Browse the repository at this point in the history

  5. Use saturating_sub when decrementing current

    @thomasschafer
    thomasschafer committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    edf568b View commit details
    Browse the repository at this point in the history

  6. Fix naming of previous jump, and remove unneeded comment change

    @thomasschafer
    thomasschafer committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    381660c View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary changes in push

    @thomasschafer
    thomasschafer committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    fa15699 View commit details
    Browse the repository at this point in the history

  8. Return num elements removed from front, and use in backward method

    @thomasschafer
    thomasschafer committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    e3b9c1f View commit details
    Browse the repository at this point in the history

  9. Hide num_removed from public interface and tidy up jump location check

    @thomasschafer
    thomasschafer committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    7278d76 View commit details
    Browse the repository at this point in the history