5.x: Helidon Services Inject #8400
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
Rebased |
spericas
reviewed
Mar 12, 2024
service/registry/src/main/java/io/helidon/service/registry/ServiceRegistryManagerDiscovery.java
Outdated
Show resolved
Hide resolved
service/registry/src/main/java/io/helidon/service/registry/CoreServiceDiscovery.java
Outdated
Show resolved
Hide resolved
service/registry/src/main/java/io/helidon/service/registry/CoreServiceRegistryManager.java
Outdated
Show resolved
Hide resolved
service/inject/api/src/main/java/io/helidon/service/inject/api/Injection.java
Outdated
Show resolved
Hide resolved
service/inject/api/src/main/java/io/helidon/service/inject/api/Injection.java
Outdated
Show resolved
Hide resolved
service/inject/api/src/main/java/io/helidon/service/inject/api/Injection.java
Outdated
Show resolved
Hide resolved
service/inject/api/src/main/java/io/helidon/service/inject/api/Injection.java
Show resolved
Hide resolved
service/inject/api/src/main/java/io/helidon/service/inject/api/Injection.java
Outdated
Show resolved
Hide resolved
service/inject/api/src/main/java/io/helidon/service/inject/api/Interception.java
Outdated
Show resolved
Hide resolved
service/inject/api/src/main/java/io/helidon/service/inject/api/ConfigDriven.java
Outdated
Show resolved
Hide resolved
* Renamed Dependent to Instance as that better describes the behavior (dependent implies full lifecycle) * Added tests for core supplier services to injection tests to verify behavior is aligned
|
Rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7957
Resolves #6647
Resolves #5697
Resolves #8222
Resolves #7083
Resolves #7052
Resolves #6768
Resolves #6646
Resolves #6620
Description
Helidon services provides a replacement for service loader with some additional features - module
helidon-service-registryIn addition we have a module with full injection, config driven, and interception support -
helidon-service-inject-apiandhelidon-service-inject(API and implementation)Best place to check the features and generated code is in the
service/testsandservice/tests/injectmodules.The PR contains also initial code for Helidon declarative, though that is not yet fully done.
This PR is ready for review of the concepts, generated code, module structure (service module and its children).
Removed the requirement to modify
module-info.javaby the user, as we use our own way of discovering and loading services.Request scope is now an optional feature even when using HTTP. This is achieved by compile time extension to support parameters through source code + additional set of services that support the same using request scope
Known Todos
io.helidon.Main)service-codegen, as it still uses the old inject based namingNew stuff unrelated to services
servicemodule uses dependency checking maven pluginservicemodule is configured to fail on javadoc warning