Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing runtime error on ActionPopup click & LOVE_ENDPOINT spelling error #5798

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Nivedit24
Copy link

@Nivedit24 Nivedit24 commented Jun 12, 2024

  • Provide a brief description of the changeset.
    • Fixing runtime error on ActionPopup click
    • Need more information what "Contact Record" click event should perform
    • Doc value was undefined when called from line 201 in ActionsPopup.svelte file
    • Fixing LOVE_ENDPOINT spelling error
  • Include a screenshots if applicable
Bug.mov
Fix.mov

Huly®: UBERF-7250

@Nivedit24 Nivedit24 changed the title Fixing runtime error on ActionPopup click Fixing runtime error on ActionPopup click & LOVE_ENDPOINT spelling error Jun 13, 2024
async function openChannelURL (doc: Channel): Promise<void> {
async function openChannelURL(doc: Channel): Promise<void> {
if (doc.value === undefined) {
return
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haiodo How to fix the formatting CI check?

Copy link
Member

@haiodo haiodo Jun 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, rush format should be called locally, for entire project. and rushx format for individual ones.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rush format is giving an error in a file unchanged by me. rushx format on the current file produces no changes

@haiodo
Copy link
Member

haiodo commented Jun 16, 2024

rush format should be called locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants