fix(ui): allow input month with keystrokes #5785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: p-fernandez <[email protected]>
BykhovDenis
approved these changes
Jun 12, 2024
|
Typo Code Review 📊 ✅ All checks passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Requirements:
Fix the calendar month input to allow to type full numerical entries. The current behaviour only allowed to input months from November (10 to 12) due skipping to year once zero was pressed.
Tested in Chrome (Version 125.0.6422.142 (Official Build) (arm64)) and Safari (Version 17.5 (19618.2.12.11.6)).
Behaviour before >
before-1024.mov
Behaviour after fix >
after-1080.mov
Signed-off-by: p-fernandez [email protected]
Huly®: UBERF-7232