UBERF-4725 Migrate collaborative content #5717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // we don't want to show collaborative documents in activity | ||
| // instead we show their content as Markup | ||
| // TODO this should be generalized via activity extension | ||
| if (attrClass === core.class.TypeCollaborativeDoc) { |
There was a problem hiding this comment.
are you planning to do it in this pull request or is it a note for the future?
There was a problem hiding this comment.
let's decide on review how we handle this
I can do in this PR but It would be also good to have async trigger because file loading may affect the trigger performance.
There was a problem hiding this comment.
we can make activity generation as asynс trigger, I thought about that too
I would prefer to do it async in a separate pull request, and merge this pull request for now if it works
You can assign this task to me
There was a problem hiding this comment.
I figured out that I need to do a bit more changes to support mixins here. Will be done tomorrow.
aonnikov
force-pushed
the
migrate-collaborative-content
branch
4 times, most recently
from
7815ffd
to
728239e
Compare
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
…ments Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
aonnikov
force-pushed
the
migrate-collaborative-content
branch
from
800165a
to
e683c9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huly®: UBERF-7136