Support Float type fields in DBReader

[simonellistonball]

This added simple support for the Float type in DBF files, which exists in some shapefile sources.

Test to come, when I dig up appropriately licensed data.

[harsha2010]

Thanks Simon, will review at earliest!

On Oct 27, 2015, at 11:38 AM, Simon Elliston Ball [email protected] wrote:

This added simple support for the Float type in DBF files, which exists in some shapefile sources.

Test to come, when I dig up appropriately licensed data.

You can view, comment on, or merge this pull request online at:

#28

Commit Summary

Added support for float data type in DBF reader
Removed test for F in DBFile Reader to avoid using ambiguously licensed data
Whitespace fix
File Changes

M src/main/scala/magellan/mapreduce/DBReader.scala (19)
Patch Links:

https://github.com/harsha2010/magellan/pull/28.patch
https://github.com/harsha2010/magellan/pull/28.diff
—
Reply to this email directly or view it on GitHub.

[simonellistonball]

Do you need an issue against this as well?

[harsha2010]

1. do you need new String(b) here, i am not in front of a IDE but i thought there is a set method on text which accepts a byte array and start/ end positions?
2. do you need clear on a newly allocated text object?

[harsha2010]

@simonellistonball , no need for an issue against this.. as soon as the code review is done and the test is in place, i can do a final pass and pull the patch in.