Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: preserve post title when opening settings #6122

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 24, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.17.x

What this PR does / why we need it:

在文章编辑页面,打开文章设置时,支持保存标题,防止已修改的标题恢复为之前的值。

Which issue(s) this PR fixes:

Fixes #6058

Does this PR introduce a user-facing change?

优化文章编辑页面自动保存标题的功能

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.76%. Comparing base (5fdf6c0) to head (4015400).
Report is 261 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6122      +/-   ##
============================================
- Coverage     56.91%   54.76%   -2.16%     
- Complexity     3319     3432     +113     
============================================
  Files           587      629      +42     
  Lines         18968    21185    +2217     
  Branches       1401     1482      +81     
============================================
+ Hits          10795    11601     +806     
- Misses         7594     8994    +1400     
- Partials        579      590      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Jun 24, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 24, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jun 24, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wzrove June 24, 2024 03:20
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
Copy link

f2c-ci-robot bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit aee3990 into halo-dev:main Jun 26, 2024
7 checks passed
@ruibaby ruibaby deleted the fix/post-title branch June 26, 2024 03:53
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

编辑文章时点击设置应同步文章标题
3 participants