fix: fix video-background reset when using notes plugin. #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the notes plugin check the difference between the states when responding to slide changes, and appropriately sends `next` or `prev` commands instead of `setState` in order to avoid resetting things like video backgrounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the notes plugin check the difference between the states when responding to slide changes, and appropriately sends
nextorprevcommands instead ofsetStatein order to avoid resetting things like video backgrounds.I needed this in my project so that I could use the notes view to remote control the slides, without really messing up the video background slide by restarting it every time I triggered the next fragment.