-
-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support merging the "skip" attribute from included files. #3225
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Rodrigo Fior Kuntzer <[email protected]>
|
Integration test
|
The `skip` flag must be set explicitly in terragrunt modules that should be skipped. If you set `skip = true` in a | ||
`terragrunt.hcl` file that is included by another `terragrunt.hcl` file, only the `terragrunt.hcl` file that explicitly | ||
set `skip = true` will be skipped. | ||
The `skip` flag can be inherited from an included `terragrunt.hcl` file if `skip` is defined there, unless it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think may be helpful to add an integration test for this case, when the skip flag is inherited from include
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestion @denis256 , I've updated the TestApplyAllSkipTrue
integration test to cover this scenario as well, it was already using an partial terragrunt file there with a skip = true
defined, so now one of the child modules is inheriting the skip
and the other is overwriting it.
…handle the case where skip is inherited from the included terragrunt file Signed-off-by: Rodrigo Fior Kuntzer <[email protected]>
Thanks for publishing the failed tests here @denis256 and sorry for not catching them initially, I've fixed them. |
Hi @denis256 , could you please share the reason why the |
Hi, 🍎 🪱 |
Description
Fixes #3224.
This PR is introducing support for merging the content of the
skip
attribute frominclude
blocks, in the same way of many other attributes and blocks are already being merged.TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].