-
-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support discovery of symlinked modules #3101
base: master
Are you sure you want to change the base?
Conversation
918d571
to
8bac38d
Compare
@denis256 This PR is ready for review, please let me know if it need changes. |
Conflicting files |
Signed-off-by: Zadkiel AHARONIAN <[email protected]>
@denis256 I just rebased! |
@@ -604,7 +606,7 @@ func GetDefaultConfigPath(workingDir string) string { | |||
func FindConfigFilesInPath(rootPath string, terragruntOptions *options.TerragruntOptions) ([]string, error) { | |||
configFiles := []string{} | |||
|
|||
err := filepath.Walk(rootPath, func(path string, info os.FileInfo, err error) error { | |||
err := symwalk.Walk(rootPath, func(path string, info os.FileInfo, err error) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering why filepath.Walk()
wasn't replaced in other places, for example in terraform/source.go
, I think it may lead to the failure of detection of changes in modules
https://github.com/search?q=repo%3Agruntwork-io%2Fterragrunt%20filepath.Walk&type=code
Signed-off-by: GitHub <[email protected]>
Quality Gate failedFailed conditions |
Description
Support discovery of symlinked modules with the help of https://github.com/edwardrf/symwalk.
Fixes #1611
TODOs
Read the Gruntwork contribution guidelines.
Release Notes
Added support for discovery of symlinked modules