Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphman copy indexing improvements #5425

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Graphman copy indexing improvements #5425

merged 1 commit into from
Jun 27, 2024

Conversation

zorancv
Copy link
Contributor

@zorancv zorancv commented May 17, 2024 •
edited
Loading

Addresses the #5140 issue. The tests are still pending.

@zorancv zorancv marked this pull request as draft May 17, 2024 12:34
@zorancv zorancv changed the base branch from master to zoran/graphman-copy-index May 17, 2024 12:36
@zorancv zorancv force-pushed the zoran/graphman-copy-same branch 2 times, most recently from 4450622 to a656ea2 Compare May 17, 2024 14:11
@zorancv zorancv force-pushed the zoran/graphman-copy-index branch from 6287b01 to 1c4f291 Compare May 17, 2024 14:13
@zorancv zorancv changed the base branch from zoran/graphman-copy-index to zoran/graphman-copy-init May 17, 2024 14:14
@zorancv zorancv changed the base branch from zoran/graphman-copy-init to zoran/graphman-copy-index May 17, 2024 14:14
@zorancv zorancv changed the base branch from zoran/graphman-copy-index to master May 17, 2024 14:18
@zorancv zorancv changed the base branch from master to zoran/graphman-copy-index May 17, 2024 14:19
@zorancv zorancv changed the base branch from zoran/graphman-copy-index to tiago/receipts-in-mappings May 17, 2024 14:20
@zorancv zorancv changed the base branch from tiago/receipts-in-mappings to zoran/graphman-copy-index May 17, 2024 14:20
@zorancv zorancv changed the base branch from zoran/graphman-copy-index to zoran/graphman-copy-init May 17, 2024 14:20
@zorancv zorancv changed the base branch from zoran/graphman-copy-init to master May 17, 2024 14:21
@zorancv zorancv force-pushed the zoran/graphman-copy-same branch 4 times, most recently from cbd2732 to 2204c6e Compare May 22, 2024 16:26
@zorancv zorancv changed the title Grahman copy indexing improvements Graphman copy indexing improvements May 23, 2024
@zorancv zorancv force-pushed the zoran/graphman-copy-same branch 10 times, most recently from 844d9e2 to 35dbb91 Compare May 29, 2024 09:38
@zorancv zorancv changed the base branch from master to zoran/graphman-copy-only May 29, 2024 11:35
@zorancv zorancv changed the base branch from zoran/graphman-copy-only to master May 29, 2024 13:11
@zorancv zorancv force-pushed the zoran/graphman-copy-same branch 12 times, most recently from 668b7c4 to 042641c Compare May 31, 2024 14:49
@zorancv zorancv marked this pull request as ready for review May 31, 2024 15:01
lutter
lutter previously requested changes Jun 8, 2024
View reviewed changes
store/postgres/src/relational/ddl_tests.rs Outdated Show resolved Hide resolved
store/postgres/src/deployment_store.rs Outdated Show resolved Hide resolved
store/postgres/src/relational/ddl.rs Outdated Show resolved Hide resolved
store/postgres/src/copy.rs Outdated Show resolved Hide resolved
store/postgres/src/copy.rs Show resolved Hide resolved
store/postgres/src/relational/index.rs Show resolved Hide resolved
store/postgres/src/relational/index.rs Outdated Show resolved Hide resolved
store/postgres/src/relational/index.rs Outdated Show resolved Hide resolved
store/postgres/src/relational/index.rs Outdated Show resolved Hide resolved
store/postgres/src/relational/prune.rs Show resolved Hide resolved
@zorancv zorancv force-pushed the zoran/graphman-copy-same branch 2 times, most recently from 850bef1 to 5a4acef Compare June 13, 2024 10:53
@fordN fordN requested a review from incrypto32 June 17, 2024 15:45
incrypto32
incrypto32 approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@incrypto32 incrypto32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some minor comments

store/postgres/src/relational/index.rs Outdated Show resolved Hide resolved
store/postgres/src/relational/index.rs Outdated Show resolved Hide resolved
@zorancv zorancv force-pushed the zoran/graphman-copy-same branch 2 times, most recently from 575164b to c3a58fa Compare June 25, 2024 11:52
@zorancv zorancv mentioned this pull request Jun 26, 2024
Open
2 tasks
@zorancv zorancv dismissed lutter’s stale review June 27, 2024 12:55

I believe that all concerns are addressed.

@zorancv zorancv merged commit ddf04aa into master Jun 27, 2024
7 checks passed
@zorancv zorancv deleted the zoran/graphman-copy-same branch June 27, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lutter lutter lutter left review comments

@incrypto32 incrypto32 incrypto32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zorancv @lutter @incrypto32