Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logging): Skip automatic resource detection if a CommonResource LoggerOption is passed in #10441

Merged
merged 4 commits into from
Jun 27, 2024
Merged

fix(logging): Skip automatic resource detection if a CommonResource LoggerOption is passed in #10441

merged 4 commits into from
Jun 27, 2024

Conversation

gkevinzheng
Copy link
Contributor

@gkevinzheng gkevinzheng commented Jun 26, 2024 •
edited
Loading

Fixes #10420

@gkevinzheng gkevinzheng requested review from a team as code owners June 26, 2024 15:07
@product-auto-label product-auto-label bot added the api: logging Issues related to the Cloud Logging API. label Jun 26, 2024
@gkevinzheng gkevinzheng enabled auto-merge (squash) June 27, 2024 19:00
@gkevinzheng gkevinzheng merged commit fc4c910 into googleapis:main Jun 27, 2024
8 checks passed
@release-please release-please bot mentioned this pull request Jun 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhshkh bhshkh bhshkh approved these changes

@daniel-sanche daniel-sanche Awaiting requested review from daniel-sanche daniel-sanche is a code owner automatically assigned from googleapis/api-logging

Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logging: too slow Logger on non GCE environment
2 participants
@gkevinzheng @bhshkh